bug-grub
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] use dynamical allocation in device.c:get_*_name ()


From: Robert Millan
Subject: Re: [PATCH] use dynamical allocation in device.c:get_*_name ()
Date: Sun, 20 Jul 2003 00:30:28 +0000
User-agent: Mutt/1.5.4i

Hi there,

I'm afraid the patch I sent some days ago was wrong, and it didn't do
what my mail described. This is because I made a mistake when sending
it and I sent a preliminary, incomplete patch instead of the correct one.

I'm attaching the correct patch, which corresponds to the message I sent:

> Hello!
> 
> This patch fixes lib/device.c to use dynamic allocation for the
> device names obtained in get_*_name () functions:
> 
>  - the name variable is returned by the functions instead of
>    passing by reference, so that they can allocate it themselves.
>  - the get_*_name functions use asprintf() to allocate the device
>    name dynamicaly.
>  - for NetBSD, it still uses static allocation since the "opendisk"
>    call is unable (that i know of) to deal with dynamic buffers.
> 
> This fix is needed to work for kernels that have device names longer than
> 16 chars, and for GCS compliance (section 4.1).

-- 
Robert Millan

Attachment: grub.diff
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]