Re: go about releasing 0.93

[Pavel Roskin]

Hello again,

> When I rebooted, the menu was fine.  However, when I pressed "c", the 
> cursor was missing.  I could type and execute any commands, I just could 
> not see the cursor.  The old version (it also was from CVS, and I don't 
> remember when I compiled it) did show the cursor properly.

I can reproduce the problem in bochs 2.0.pre2 with the included LPGLed
video BIOS.  Loading the menu kills the cursor, but exiting the menu by 
"c" doesn't restore it.

I'm not sure if console_cls() is the right place to restore the cursor.  
However, this patch works for me.

===========================
--- stage2/asm.S
+++ stage2/asm.S
@@ -2160,6 +2160,11 @@
        movb    $0x02, %ah
        int     $0x10
 
+       /* set cursor type */
+       movw    $0x0c0d, %cx
+       movb    $0x1, %ah
+       int     $0x10 
+
        DATA32  call    EXT_C(real_to_prot)
        .code32
 
===========================

> Later I found that if I run "testvbe 0x101" and press Enter during the 
> test, the cursor appears.

So the alternative solution would be to call set_vbe_mode(0x03) in 
console_cls(), but I think it's too heavy-handed.

0x0c0d creates cursor two lines high.  The lower line is on the same level
as the lowest line of the letter "j".  This is exactly the same cursor
shape as the one that appears after set_vbe_mode().  Not sure if it's a
standard.

-- 
Regards,
Pavel Roskin