bug-grub
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Resolving symllinks in grub-install


From: Yoshinori K. Okuji
Subject: Re: Resolving symllinks in grub-install
Date: Sat, 09 Feb 2002 13:04:11 +0900
User-agent: Wanderlust/2.6.0 (Twist And Shout) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (Unebigoryoae) APEL/10.3 Emacs/20.7 (i686-pc-linux-gnu) MULE/4.0 (HANANOEN)

At Fri, 8 Feb 2002 18:32:00 -0500 (EST),
Pavel Roskin wrote:
> This patch fixes the problem by resolving symlinks.  A new function, 
> resolve_links() takes a variable name as an argument.  It takes the 
> filename from the variable, resolves it until it becomes a real file, not 
> a symlink, and puts the result to the same variable.

I don't like setting the variable within the function. Such code is a
bit difficult to read.

> If anybody wants, I can go one step further to include "df" into that
> function, making it a function to determine the block device for the given
> file.

I think that's better. There is no reason for the separation.

Thanks,
Okuji



reply via email to

[Prev in Thread] Current Thread [Next in Thread]