Re: VBE

[OKUJI Yoshinori]

From: Jan Fricke <address@hidden>
Subject: VBE
Date: Sun, 19 Nov 2000 23:32:33 +0100

> While testing the VBE functions of "grub" I thought may be one
> can do more than only rotate colors. So I changed the function
> "testvbe" to a function "tetris" which has to be called with
> an 8 bpp VBE mode. If you think it is funny enough to added
> to "grub" I will make a "proper" diff, i.e. comment everything,
> use nicer variable names, write "ChangeLog" entry...

  Hehe.. Personally, I like this kind of fun. But probably I should
reject the patch as the maintainer - because of the same reason why I
haven't applied my "beep" MIDI player to the CVS. :)

  Seriously, I think it would be better to do a bit more meaningful
thing in testvbe, as anyone cannot know if it is really
working. He/She knows only that it does something and it doesn't
hang. For the purpose of testvbe, it must be possible to switch to any
VBE mode supported by your card. So your patch isn't very
good. Another reason is that it does too many things for merely a
test.

Cheers,
Okuji