[bug #64005] [ms] fix for Savannah #62688 has backwards test

[G. Branden Robinson]

Update of bug #64005 (group groff):

                  Status:               Need Info => In Progress            
                 Summary: [ms] fix for Savannah #62688 suppresses page breaks
between displays => [ms] fix for Savannah #62688 has backwards test

    _______________________________________________________

Follow-up Comment #8:


> I think there may be a problem with this fix.

Good catch, Deri.

The regression test didn't catch it because the regression test didn't concern
itself with which control character was used to call the `bp` macro, and
moreover was used in a context where a line had just been broken anyway.

A new regression test reveals the same problem you found.

I got my wires crossed.

Here's the fix.


diff --git a/tmac/s.tmac b/tmac/s.tmac
index d3896c791..547eb9ec6 100644
--- a/tmac/s.tmac
+++ b/tmac/s.tmac
@@ -104,8 +104,8 @@ .de di
 .de bp
 .      nr @saved-no-space-mode \\n[.ns]
 .      rs
-.      ie \\n[.br] '@break-page \\$1
-.      el          .@break-page \\$1
+.      ie \\n[.br] .@break-page \\$1
+.      el          '@break-page \\$1
 .      if \\n[@saved-no-space-mode] .ns
 .      rr @saved-no-space-mode
 ..




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?64005>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/