[bug #64957] [troff] commit 429723c3ec broke `device` and `output` requests, and `pdfbackground`

[G. Branden Robinson]

Update of bug #64957 (project groff):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.24.0                 

    _______________________________________________________

Follow-up Comment #1:


commit 0b403f7971e7b7965f7853b05dec3ce1128f943e
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Fri Dec 1 13:57:47 2023 -0600

    [troff]: Fix Savannah #64957 (`device`, `output`).
    
    ...requests were broken.
    
    The GNU troff(1) internal function `has_arg()` has a side effect of
    advancing the token pointer (a sort of cursor into the input stream).
    So when I changed `device_request()` and `output_request()` to use
    `has_arg()` in commit 429723c3ec (10 November), the first character of
    the argument got stripped, making it unintelligible to the output
    driver.
    
    * src/roff/troff/input.cpp (device_request, output_request): Drop call
      of `has_arg()` in favor of `input_stack::peek()`.  Manually discard
      space characters until reaching something else; if that is a newline
      or EOF, bail out of request processing.  Otherwise, proceed with
      warning diagnostic as before.




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?64957>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/