[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #64360] [PATCH] [gropdf] does not correctly handle white space afte
From: |
Dave |
Subject: |
[bug #64360] [PATCH] [gropdf] does not correctly handle white space after 'w' command |
Date: |
Wed, 28 Jun 2023 10:54:36 -0400 (EDT) |
Follow-up Comment #20, bug #64360 (project groff):
[comment #19 comment #19:]
> my $lin=substr($_,1);
> + $lin=~s/^\s*//;
One nit: as long as you're already unleashing a regex, you may as well use it
to also perform the edit substr() is doing, and remove that function call.
my $lin=$_;
$lin=~s/^.\s*//;
Similar code appears a few lines down as well and can be similarly combined
(this time saving a line of code because you can eliminate an assignment).
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?64360>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [bug #64360] [gropdf] does not correctly handle white space after 'w' command, (continued)
- [bug #64360] [gropdf] does not correctly handle white space after 'w' command, Deri James, 2023/06/27
- [bug #64360] [gropdf] does not correctly handle white space after 'w' command, G. Branden Robinson, 2023/06/27
- [bug #64360] [gropdf] does not correctly handle white space after 'w' command, Deri James, 2023/06/27
- [bug #64360] [gropdf] does not correctly handle white space after 'w' command, G. Branden Robinson, 2023/06/27
- [bug #64360] [gropdf] does not correctly handle white space after 'w' command, Deri James, 2023/06/27
- [bug #64360] [gropdf] does not correctly handle white space after 'w' command, G. Branden Robinson, 2023/06/27
- [bug #64360] [gropdf] does not correctly handle white space after 'w' command, Dave, 2023/06/27
- [bug #64360] [gropdf] does not correctly handle white space after 'w' command, G. Branden Robinson, 2023/06/28
- [bug #64360] [gropdf] does not correctly handle white space after 'w' command, G. Branden Robinson, 2023/06/28
- [bug #64360] [PATCH] [gropdf] does not correctly handle white space after 'w' command, G. Branden Robinson, 2023/06/28
- [bug #64360] [PATCH] [gropdf] does not correctly handle white space after 'w' command,
Dave <=
- [bug #64360] [PATCH] [gropdf] does not correctly handle white space after 'w' command, Dave, 2023/06/28
- [bug #64360] [PATCH] [gropdf] does not correctly handle white space after 'w' command, G. Branden Robinson, 2023/06/28
- [bug #64360] [PATCH] [gropdf] does not correctly handle white space after 'w' command, Deri James, 2023/06/28
- [bug #64360] [PATCH] [gropdf] does not correctly handle white space after 'w' command, Deri James, 2023/06/28
- [bug #64360] [PATCH] [gropdf] does not correctly handle white space after 'w' command, G. Branden Robinson, 2023/06/29