[bug #64183] [pdfroff]: sanitize.tmac throws warning when -ww specified

[Keith Marshall]

URL:
  <https://savannah.gnu.org/bugs/?64183>

                 Summary: [pdfroff]: sanitize.tmac throws warning when -ww
specified
                   Group: GNU roff
               Submitter: keithmarshall
               Submitted: Thu 11 May 2023 09:14:45 PM UTC
                Category: General
                Severity: 3 - Normal
              Item Group: Warning/Suspicious behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Thu 11 May 2023 09:14:45 PM UTC By: Keith Marshall <keithmarshall>
After patching test-groff, per attached, to allow me to run pdfroff within the
groff build tree, and formatting pdfroff.1 as PDF, using my own as yet
unpublished anpdf.tmac, I see:

$ CMD=pdfroff ./test-groff -ww -manpdf -dpaper=a4 -P-pa4 -rFT='(-0.75i)'
../groff-pdfmark/build/pdfroff.1 > pdfroff.1.pdf
troff:../groff-pdfmark/build/pdfroff.1:2: warning: end index of substring out
of range, set to string length
...

(the same warning is repeated a further eight times, originating from
differing line numbers within pdfroff.1).

The warning originates from contrib/pdfmark/sanitize.tmac, after inspection of
the last character in the pdfhref address string, when attempting to discard
this character from the residual string.

I've already fixed this in
[https://osdn.net/users/keith/pf/groff-pdfmark/scm/tree/tip/ groff-pdfmark, at
OSDN]; a patch, relative to your contrib/pdfmark version, (which also adds
some additional filters from my version of sanitize.tmac, which are not in
yours), is attached.






    _______________________________________________________
File Attachments:


-------------------------------------------------------
Date: Thu 11 May 2023 09:14:45 PM UTC  Name: test-groff-command.patch  Size:
381B   By: keithmarshall

<http://savannah.gnu.org/bugs/download.php?file_id=54728>
-------------------------------------------------------
Date: Thu 11 May 2023 09:14:45 PM UTC  Name: reference-sanitizer.patch  Size:
7KiB   By: keithmarshall

<http://savannah.gnu.org/bugs/download.php?file_id=54729>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?64183>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/