[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #64105] [eqn] off-by-one error in line numbering

From: G. Branden Robinson
Subject: [bug #64105] [eqn] off-by-one error in line numbering
Date: Sun, 30 Apr 2023 07:35:04 -0400 (EDT)

Follow-up Comment #1, bug #64105 (project groff):

I have a fix in my working copy, with further regression tests.

commit 254befbbde98b0b55e6521ae5a159f2733835b46
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sun Apr 30 06:06:51 2023 -0500

    [eqn]: Fix Savannah #64105.
    * src/preproc/eqn/main.cpp (do_file): Increment the line number if a
      malformed `lf` request was encountered, instead of decrementing it if
      a valid one was.  Increment it when processing an end eqn macro call
      (".EN"), not just a start one.  Drop an incrementation of the line
      number that applied too generally.
    This ensures we don't throw the line numbers off in normal input
    processing.  Fixes a problem introduced by me in commit dc98a8b09e, 31
    Fixes <https://savannah.gnu.org/bugs/?64105>.

commit e185954f414bbf85c53146215b2e3e4b6daf3470
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Sun Apr 30 06:03:08 2023 -0500

    [eqn]: Improve tests of line number accuracy.
    * src/preproc/eqn/tests/diagnostics-report-correct-line-numbers.sh: Add
      cases to check behavior of valid input, not just error cases.
    Test fails at this commit.


Reply to this item at:


Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]