[bug #61348] [troff] assertion in env.cpp:distribute_space() has to come out

[G. Branden Robinson]

URL:
  <https://savannah.gnu.org/bugs/?61348>

                 Summary: [troff] assertion in env.cpp:distribute_space() has
to come out
                 Project: GNU troff
            Submitted by: gbranden
            Submitted on: Mon 18 Oct 2021 10:53:08 AM UTC
                Category: Core
                Severity: 3 - Normal
              Item Group: Incorrect behaviour
                  Status: In Progress
                 Privacy: Public
             Assigned to: gbranden
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

I added an `assert()` to `distribute_space()` last month in commit b93eacd8d7,
but it as with Gumby brain surgery, it has to come out.

It breaks the hyphenation point detector that we've had kicking around on the
groff list for a few years (at least).

The reason is that the amount of desired space can be negative if the line is
overrunning.


.hy 4
.ll 1u
troff: backtrace: file '<standard input>':2
troff: <standard input>:2: warning: invalid line length 0u rounded to device
horizontal resolution
struct\~sockaddr_mctp
troff: backtrace: file '<standard input>':3
troff: <standard input>:3: warning [p 1, 0.0i]: can't break line
troff: backtrace: file '<standard input>':3
troff: <standard input>:3: debug: GBR: desired_space is -264
troff: backtrace: file '<standard input>':3
troff: <standard input>:3: debug: GBR: nspaces is 1
troff: ../src/roff/troff/env.cpp:2065: distribute_space(): assertion failed:
'desired_space > 0'
/home/branden/src/GIT/groff/build/groff: error: troff: Aborted (core dumped)





    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61348>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/