[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #61315] Several groff source files don't include <config.h> first
From: |
Paul Eggert |
Subject: |
[bug #61315] Several groff source files don't include <config.h> first |
Date: |
Sat, 9 Oct 2021 16:20:14 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:93.0) Gecko/20100101 Firefox/93.0 |
Follow-up Comment #3, bug #61315 (project groff):
The fix for ticket #59276 does not suffice for current Gnulib.
The proposed patch causes Groff to include <config.h> before including any
file supplied by the system. This suffices to make Groff robust for both
current and future Gnulib, and it is nearly equivalent to Ingo's suggestion to
"include config.h everywhere no matter whether it is needed or not". (I write
"nearly equivalent" because the proposed patch does not affect
src/utils/addftinfo/guess.cpp even though Ingo's suggestion would alter that
file.)
Gnulib keeps evolving mostly because POSIX, C, C++, glibc, etc. keep evolving.
The Groff source can of course handle this sort of evolution on its own. My
suggestion, though, is to take advantage of Gnulib when this saves you work
overall, even if there are minor glitches such as the one embodied in the
proposed patch.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?61315>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [bug #61315] Several groff source files don't include <config.h> first, Paul Eggert, 2021/10/09
- [bug #61315] Several groff source files don't include <config.h> first, G. Branden Robinson, 2021/10/09
- Re: [bug #61315] Several groff source files don't include <config.h> first, Bjarni Ingi Gislason, 2021/10/09
- [bug #61315] Several groff source files don't include <config.h> first, Ingo Schwarze, 2021/10/09
- Re: [bug #61315] Several groff source files don't include <config.h> first, Werner LEMBERG, 2021/10/09
- Re: [bug #61315] Several groff source files don't include <config.h> first, Ingo Schwarze, 2021/10/09
- Re: [bug #61315] Several groff source files don't include <config.h> first, Werner LEMBERG, 2021/10/09
- Re: [bug #61315] Several groff source files don't include <config.h> first, Paul Eggert, 2021/10/09
- Re: [bug #61315] Several groff source files don't include <config.h> first, Ingo Schwarze, 2021/10/09
- Re: [bug #61315] Several groff source files don't include <config.h> first, Paul Eggert, 2021/10/10
- [bug #61315] Several groff source files don't include <config.h> first,
Paul Eggert <=
- [bug #61315] [PATCH] several source files don't include <config.h> first, G. Branden Robinson, 2021/10/10
- [bug #61315] [PATCH] several source files don't include <config.h> first, G. Branden Robinson, 2021/10/10