[bug #61315] Several groff source files don't include <config.h> first

[Paul Eggert]

URL:
  <https://savannah.gnu.org/bugs/?61315>

                 Summary: Several groff source files don't include <config.h>
first
                 Project: GNU troff
            Submitted by: eggert
            Submitted on: Sat 09 Oct 2021 12:51:06 AM PDT
                Category: None
                Severity: 3 - Normal
              Item Group: Build/Installation
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:

Gnulib-using apps are supposed to include <config.h> first, if they use any
feature that Gnulib might affect. Since Gnulib redefines standard headers,
this means pretty much every source file must include <config.h> first. The
Groff source code forgets to do this in some places. Although this is OK with
the current groff master branch (commit
2ab0dacb95863a2e347d06cf970676c74c784ce2), it won't work once you update Groff
to current Gnulib, as reported by Bjarni Ingi Gislason here:

https://lists.gnu.org/r/bug-gnulib/2021-10/msg00008.html

The obvious fix is to include <config.h> first in every source file that isn't
doing that already. Proposed patch attached.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 09 Oct 2021 12:51:06 AM PDT  Name:
0001-gnulib-Include-config.h-first.patch  Size: 9KiB   By: eggert
Modify Groff to include &lt;config.h&gt; first.
<http://savannah.gnu.org/bugs/download.php?file_id=52080>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61315>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/