[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #60612] [man] FT register should get more validation
|
From: |
G. Branden Robinson |
|
Subject: |
[bug #60612] [man] FT register should get more validation |
|
Date: |
Sun, 16 May 2021 20:43:00 -0400 (EDT) |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 |
Update of bug #60612 (project groff):
Status: None => In Progress
Assigned to: None => gbranden
_______________________________________________________
Follow-up Comment #1:
Instrumenting the chunk of TH that sets up the traps (with .ptr) is
revealing.
$ ./build/test-groff -Tutf8 -man -rFT=-0.55v -rcR=0
./build/src/preproc/eqn/neqn.1 | grep 'groff 1\.23'
an-header 0
an-footer -240
an-p-footer -40
groff 1.23.0.rc1.456-ebc26 7 May 2021
1
$ ./build/test-groff -Tutf8 -man -rFT=-0.51v -rcR=0
./build/src/preproc/eqn/neqn.1 | grep 'groff 1\.23'
an-p-footer 0
an-footer -240
an-p-footer, which "prepares" the footer in an environment, ensuring that the
point size and line spacing are sane and a bunch of strings are munged in
readiness for the .tl request in .BT, is planted at FT. But bad values of FT
somehow become zero, which is not only an inappropriate place, but hides the
an-header trap.
Definitely bad mojo: input validation is required here.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?60612>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/