[bug #59812] tbl: interferes with .nm line numbering

[G. Branden Robinson]

Update of bug #59812 (project groff):

                  Status:               Confirmed => Fixed                  
             Assigned to:                    None => gbranden               
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.23.0                 

    _______________________________________________________

Follow-up Comment #4:


commit 633de5c27e299ba9421ca8ba298a5bc90e56ff1c (HEAD -> master,
origin/master, origin/HEAD)
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Feb 25 17:28:43 2021 +1100

    Fix Savannah #59812.
    
    Fix bug where having line numbering off but the output line number
    register \n[ln] set to a positive value would cause tbl(1) table rows to
    spontaneously become numbered.  Use new \n[.nm] register to determine
    whether line numbering is enabled.
    
    * src/preproc/tbl/table.cpp (table::init_output, table::do_row,
      table::do_bottom): Predicate all conditions on \n[ln] additionally on
      \n[.nm].
    
    Thanks to Olle Lögdahl for the report.  Problem appears to date back to
    commit b69062693d3360efce9d4d63fac337be21e07db7, 20 July 2011.
    
    Fixes <https://savannah.gnu.org/bugs/?59812>.

commit b80434b3ebaef62fb8951c4b0b7c3de023742f1d
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Feb 25 15:08:56 2021 +1100

    Add regression test for Savannah #59812.
    
    * src/preproc/tbl/tests/cooperate-with-nm-request.sh: Do it.
    * src/preproc/tbl/tbl.am (tbl_TEST): Run test.
    
    Test will fail at this commit.

commit 8ebfa98ccdaead192ff13232107d2f376f8115a8
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Feb 25 09:32:18 2021 +1100

    Implement new read-only register ".nm".
    
    It reports the enablement status of output line numbering (caused by the
    .nm request) irrespective of the temporary suspension of numbering with
    the .nn request.  Needed because there was no way to introspect its
    state, tbl(1) needs to do so, and the writable line number register
    \n[ln] is not a reliable proxy for it.

    * src/roff/troff/env.h: Add get_numbering_nodes(), returning `int`,  to
      public interface of `environment` class.
    * src/roff/troff/env.cpp: Implement get_numbering_nodes().
    
    * src/roff/groff/tests/dot-nm_register_works.sh: Test it.
    * src/roff/groff/groff.am (groff_TESTS): Run test.
    
    * doc/groff.texi (Miscellaneous):
    * man/groff_diff.7.man (Language/New number registers):
    * man/groff.7.man (Registers/Read-only registers): Document it.
    
    * NEWS: Add item.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59812>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/