[bug #55257] xtotroff.c: Defined size of the array "encoding" is too short

[G. Branden Robinson]

Update of bug #55257 (project groff):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 
         Planned Release:                    None => 1.23.0                 

    _______________________________________________________

Follow-up Comment #4:

I forgot the bug-closing annotation in the ChangeLog; I'll fix that in a
separate commit.


commit 29385650a04a339dbb49b684eb7b2d40ed5b6beb
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Tue Dec 1 16:37:16 2020 +1100

    [xtotroff]: Avoid overrunning buffer write.
    
    * src/utils/xtotroff/xtotroff.c (MapFont): Avoid writing past
      the end of a static buffer.  Problem found and patch supplied by
      Bjarni Ingi Gislason.  I tweaked it to comment it differently (in case
      the buffer ever needs to grow, but the prospects of future X11
      server-side font rendering development seem dim) and use snprintf()
      instead of retaining the existing sprintf().
    
      Quiets warning: '%s' directive writing up to 255 bytes into a region
      of size between 0 and 255 [-Wformat-overflow=].


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55257>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/