bug-groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #55044] [PATCH] contrib/hdtbl/hdmisc.tmac-u: register 'M#' must be


From: Ingo Schwarze
Subject: [bug #55044] [PATCH] contrib/hdtbl/hdmisc.tmac-u: register 'M#' must be reset to 0 at the start of a new page
Date: Sat, 17 Nov 2018 18:21:01 -0500 (EST)
User-agent: Mozilla/5.0 (X11; OpenBSD amd64; rv:62.0) Gecko/20100101 Firefox/62.0

Update of bug #55044 (project groff):

              Item Group:                Wishlist => Incorrect behaviour    
                  Status:                    None => Confirmed              
                 Summary: [PATCH] contrib/hdtbl/hdmisc.tmac-u: Initialize
register 'M#' => [PATCH] contrib/hdtbl/hdmisc.tmac-u: register 'M#' must be
reset to 0 at the start of a new page

    _______________________________________________________

Follow-up Comment #1:

This is not the first time that i'm telling you that you keep spamming us with
trivial patches without understanding what you are doing.  Even though these
patches are trivial, this one is again incorrect.

Simple code inspection shows that there is an actual bug here, and your patch
would only make that bug harder to find.

Consider the following test file:

some
.br
lines
.br
of
.br
text
.t*SP
.bp
one line only
.br
.t*SP
missing space before this line

Expected output should have a blank line between "one line only" and "missing
space before this line".  Actual output lacks that blank line.  The reason for
this bug is that contrary to the (german) comment, \n[M#] is not reset at the
start of a new page.  The macro .HM mentioned in that comment doesn't even
exist, it was deleted eight years ago.  But even before that, it did not reset
\n[M#] - the bug is likely present since import in 2006 and was likely
introduced by pre-import changes of the original authors.

It is not completely clear to me yet how to fix it.  Somehow, \n[M#] must be
reset to zero when a new page starts.  The same bug might affect columnated
text as well, so it may also need resetting at the start of a new column.

The low code quality of the hdtbl macros is really annoying, they are buggy as
hell, and the missing initializations are the least among the problems.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?55044>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]