[bug #54666] [PATCH] pic.ypp: useless rule in parser due to conflicts

[Bjarni Ingi Gislason]

URL:
  <https://savannah.gnu.org/bugs/?54666>

                 Summary: [PATCH] pic.ypp: useless rule in parser due to
conflicts
                 Project: GNU troff
            Submitted by: bjarniig
            Submitted on: Sat 15 Sep 2018 11:03:11 PM UTC
                Category: Preprocessor pic
                Severity: 3 - Normal
              Item Group: Build/Installation
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:


>From 78d27b370c61a65ede2c7a8d3bb4c130a729dff3 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <address@hidden>
Date: Sat, 15 Sep 2018 22:17:13 +0000
Subject: [PATCH] pic.ypp: useless rule in parser due to conflicts

  Output from "make" with gcc-8.2.0:

  YACC     src/preproc/pic/pic.cpp
  YACC     src/preproc/refer/label.cpp
.../groff/src/preproc/pic/pic.ypp:1391.11-1396.17: warning: rule useless in
parser due to conflicts [-Wother]
        | ORDINAL LAST object_type relative_path
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  The test seems to be of no concern and may thus be removed.
Otherwise, those who know what this means and is about, should replace
it with a correct test.

Signed-off-by: Bjarni Ingi Gislason <address@hidden>
---
 src/preproc/pic/pic.ypp | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/preproc/pic/pic.ypp b/src/preproc/pic/pic.ypp
index 54ff44ab..a09b7ec2 100644
--- a/src/preproc/pic/pic.ypp
+++ b/src/preproc/pic/pic.ypp
@@ -1388,12 +1388,6 @@ path:
                  $$->set_ypath($4);
                }
        /* The rest of these rules are a compatibility sop. */
-       | ORDINAL LAST object_type relative_path
-               {
-                 lex_warning("'%1%2 last %3' in 'with' argument ignored",
-                             $1, ordinal_postfix($1), object_type_name($3));
-                 $$ = $4;
-               }
        | LAST object_type relative_path
                {
                  lex_warning("'last %1' in 'with' argument ignored",
-- 
2.18.0






    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?54666>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/