[bug #51587] [PATCH] src: preconv.cpp: Add a missing comma in the argument list of "printf"

[Bjarni Ingi Gislason]

URL:
  <http://savannah.gnu.org/bugs/?51587>

                 Summary: [PATCH] src: preconv.cpp: Add a missing comma in the
argument list of  "printf"
                 Project: GNU troff
            Submitted by: bjarniig
            Submitted on: Thu 27 Jul 2017 12:49:15 AM UTC
                Severity: 3 - Normal
              Item Group: Incorrect behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None

    _______________________________________________________

Details:


>From cc61328abb08b05a648fd923a6ff6d23433a2b4f Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <address@hidden>
Date: Thu, 27 Jul 2017 00:16:37 +0000
Subject: [PATCH] src: preconv.cpp: Add a missing comma in the argument list
of
 "printf"

  Warning by "gcc" version 6.4.0 with:

CFLAGS='-Wall -Wextra -Wformat=2 -Wmissing-prototypes -Wmissing-declarations'
CFLAGS="$CFLAGS "'-Wold-style-definition -Wstrict-prototypes'
CFLAGS="$CFLAGS "'-fstack-protector-strong -fno-common -funsigned-char'

CXXFLAGS="$CFLAGS "'-Wold-style-cast'

src/preproc/preconv/preconv.cpp: In function 'int main(int, char**)':
src/preproc/preconv/preconv.cpp:1233:6: warning: format '%s' expects a
matching 'char*' argument [-Wformat=]
      );

Signed-off-by: Bjarni Ingi Gislason <address@hidden>
---
 src/preproc/preconv/preconv.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/preproc/preconv/preconv.cpp
b/src/preproc/preconv/preconv.cpp
index b7241b0b..35e22eda 100644
--- a/src/preproc/preconv/preconv.cpp
+++ b/src/preproc/preconv/preconv.cpp
@@ -1221,9 +1221,9 @@ main(int argc, char **argv)
       printf("GNU preconv (groff) version %s %s iconv support and %s uchardet
support\n",
             Version_string,
 #ifdef HAVE_ICONV
-            "with"
+            "with",
 #else
-            "without"
+            "without",
 #endif /* HAVE_ICONV */
 #ifdef HAVE_UCHARDET
              "with"
-- 
2.13.2






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51587>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/