Re: Minor patch: Missing mkstemp declaration in groff 1.17.2 (now probs with snprintf/vsnprintf groff-latest)

[Phil Lobbes]

Hi,

On your suggestion, I tried building the groff-current to be sure the
mkstemp problem was fixed.  It was, but there are new problems now.

Most/all new problems seem to be related with snprintf/vsnprintf
(things that don't exist on solaris 2.5.1, I'll have to upgrade this
old box someday :-).

So here are a few possible changes...

1) src/preproc/pic/pic.cc:

[preproc/pic] ultra(2228)> diff pic.cc.ORIG pic.cc
15a16,21
> #ifndef HAVE_SNPRINTF
> extern "C" {
>   int snprintf(char *str, size_t str_m, const char *fmt, /*args*/ ...);
> }
> #endif
>

2) src/preproc/html:

[preproc/html] ultra(2231)> diff pre-html.cc.ORIG pre-html.cc
79a80,83
> #ifndef HAVE_SNPRINTF
>   int vsnprintf(char *str, size_t str_m, const char *fmt, va_list ap);
> #endif
>

3) (no patch for this one) update libgroff to also export vsnprintf
   otherwise pre-html.o will have an unresolved symbol:

  gmake[2]: Entering directory
    `/export/site/src/groff/groff-current/src/preproc/html' 
  g++ -R/site/gcc/default/lib  -o pre-grohtml pre-html.o pushback.o
    /export/site/src/groff/groff-current/src/libs/libgroff/libgroff.a
  Undefined                       first referenced
  symbol                             in file
    vsnprintf(char *, unsigned int, char const *, void *)pre-html.o
  ld: fatal: Symbol referencing errors. No output written to pre-grohtml
  collect2: ld returned 1 exit status

Hope this helps,
Phil


> > pre-html.cc: In function `int makeTempFiles()':
> > pre-html.cc:1373: implicit declaration of function `int mkstemp(...)
> 
> It should have been fixed already.  Please get the current snapshot
> from
> 
>   ftp://ftp.ffii.org/pub/groff/devel/groff-current.tar.gz
> 
> and check whether it still makes problems.
> 
>     Werner