[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher

From: Paul Eggert
Subject: bug#34951: [PATCH] grep: a kwset matcher not work in a grep matcher
Date: Fri, 13 Dec 2019 12:00:58 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

I see that Paul has made the change to the API over my objections.

I made the change while responding to Bruno's objections, but before seeing yours. Ooops. Sorry about that. However, I hope the followup emails have addressed your comments, at least to some extent.

Paul, can you point to a link that lists the benefits/tradeoffs? If I
had such a link handy, I would have provided it here.

Avoiding unsigned types for indexes and sizes seems to be a growing movement. Admittedly there are arguments for unsigned, but these arguments are getting weaker with time. Here are a couple of links, the first for C and the second for C++:



As for ssize_t vs ptrdiff_t: ssize_t is less central to the C language (ptrdiff_t is in the C standard but ssize_t is not). And ssize_t is less convenient: for example, there's no simple, portable way to printf an ssize_t value, as there is with "%td" and ptrdiff_t. So there are technical reasons for preferring ptrdiff_t to ssize_t for this sort of thing (even though "ssize_t" is a shorter and better name). Thich is why Emacs, other parts of Gnulib, and other Gnu applications have used ptrdiff_t instead of ssize_t for this sort of thing.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]