|
From: | Paul Eggert |
Subject: | bug#29123: [PATCH] grep: mark matchers table const |
Date: | Fri, 3 Nov 2017 01:45:07 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
Zev Weiss wrote:
-static struct +static const struct { char const name[12];
There's already a const after the } at the end of the struct, so this 'const' is not needed. The usual style in 'grep' is to put the 'const' after the type, not before it.
Come to think of it, the 'const' in front of 'name' is also a duplicate, so I installed the attached.
0001-grep-omit-a-dup-const.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |