[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25971: POSIX path separator used in cfg.mk breaks makefiles for all

From: Juan Manuel Guerrero
Subject: bug#25971: POSIX path separator used in cfg.mk breaks makefiles for all OS that do not use colon as path separator
Date: Sun, 05 Mar 2017 08:03:31 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv: Gecko/20101206 SUSE/3.1.7 Thunderbird/3.1.7

I do not known if this has already been reported, but the prepending of
$(srcdir)/src to the PATH in cfg.mk makes it impossible to build grep on
all OS where the path separator is different from colon.  I would suggest
to use PATH_SEPARATOR instead of hard coding the UNIX path separator making
the implicit assumption that this will DTRT for all other OS too.  The
current implementation ruins the syntax of the PATH because of mixed path
separator characters and inhibits make to find any program at all.
Please see patch below.

Juan M. Guerrero

diff -aprNU5 grep-2.28.orig/cfg.mk grep-2.28/cfg.mk
--- grep-2.28.orig/cfg.mk       2017-01-01 11:34:28 +0000
+++ grep-2.28/cfg.mk    2017-03-05 01:18:46 +0000
@@ -15,11 +15,11 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.

 # Cause the tool(s) built by this package to be used also when running
 # commands via e.g., "make syntax-check".  Doing this a little sooner
 # would have avoided a grep infloop bug.
-export PATH := $(srcdir)/src:${PATH}
+export PATH := $(srcdir)/src$(PATH_SEPARATOR)${PATH}

 # Used in maint.mk's web-manual rule
 manual_title = GNU Grep: Print lines matching a pattern

 # Use the direct link.  This is guaranteed to work immediately, while

reply via email to

[Prev in Thread] Current Thread [Next in Thread]