[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25707: [PATCH] grep: don't forcefully strip carriage returns

From: Paul Eggert
Subject: bug#25707: [PATCH] grep: don't forcefully strip carriage returns
Date: Thu, 16 Feb 2017 08:57:50 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 02/15/2017 06:23 AM, Eric Blake wrote:
xfreopen() may need a patch

Thanks for pointing out the problems with my suggestion. I think I'd rather leave xfreopen alone, as silently adjusting its argument from "wb" to "ab" might cause other problems. Instead, I added a Gnulib module to set the file's text-vs-binary mode and changed grep to use that, by installing the attached patches, which I hope address your comments.

Attachment: 0001-build-update-gnulib-submodule-to-latest.patch
Description: Source code patch

Attachment: 0002-Fix-up-recent-U-patches.patch
Description: Source code patch

reply via email to

[Prev in Thread] Current Thread [Next in Thread]