[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25707: [PATCH] grep: don't forcefully strip carriage returns

From: Paul Eggert
Subject: bug#25707: [PATCH] grep: don't forcefully strip carriage returns
Date: Tue, 14 Feb 2017 15:08:11 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 02/13/2017 12:20 PM, Eric Blake wrote:
undossify_input causes more problems than it
solves.  We should trust fopen("r") to do the right thing, rather than
reinventing it ourselves.

Yes, that makes sense. Attached is a proposed patch to implement this. It assumes the patch you already submitted for Bug#25707.

This patch keeps the -U option, for MS-Windows users who want to override fopen "-r"'s choice of binary vs text I/O. Perhaps that's too conservative? It would be easy to turn -U into a no-op too.

Attachment: 0001-Simplify-U-on-MS-Windows-by-removing-guesswork.txt
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]