bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24259: [PATCH 0/6] dfa: thread safety


From: Zev Weiss
Subject: bug#24259: [PATCH 0/6] dfa: thread safety
Date: Sat, 20 Aug 2016 20:17:19 -0500
User-agent: Mutt/1.6.2-neo (2016-07-23)

On Sat, Aug 20, 2016 at 05:52:09PM -0700, Jim Meyering wrote:
On Thu, Aug 18, 2016 at 3:50 AM, Zev Weiss <address@hidden> wrote:
Hello,
<snip>

Thank you for separating those so nicely.
I have pushed your patches 2..6, now, so will close this.
The only changes I made were to the formatting and member ordering of
struct lexer_state. At first glance, I thought reordering would save
some space, but ended up with a size of 56 bytes on x86_64 regardless.
However, I did move both "int cur_mb_len" and "bool laststart" to the
end, and note that changing the type of cur_mb_len to short int
(perhaps in a later patch) will reduce the size of that struct to 48.

Thanks, Jim.

Also, after your comments on the first patch I noticed there were a couple more function parameters that could have been const in the subsequent patches as well; the attached patch marks them as such.


Zev

Attachment: 0001-dfa-constify-some-function-parameters.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]