[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#21266: [PATCH] dfa: simplify for non-POSIX locales

From: Paul Eggert
Subject: bug#21266: [PATCH] dfa: simplify for non-POSIX locales
Date: Wed, 6 Jul 2016 19:55:47 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.8.0

Thanks, I merged those two patches and installed them into the grep master, with minor adjustments to the commit messages. I also installed two minor fixup patches, mostly fixing minor style issues. I did notice one minor technical issue; the second patch had code that looked like this:

 +  context = (wc == (wchar_t) eolbyte || wc == 0) ? CTX_NEWLINE : CTX_NONE;

I realize this came from the old wchar_context function, but I don't see why that "|| wc == 0" is there, so I removed it. The tests still pass. If you (or someone else) can explain why it's needed I can put it back in.

Attached are the four patches I installed; the first and third are your patches and the second and fourth are the fixups.

Attachment: 0001-dfa-simplify-for-non-POSIX-locales.patch
Description: Text Data

Attachment: 0002-dfa-minor-cleanups-for-non-POSIX-simplification.patch
Description: Text Data

Attachment: 0003-dfa-don-t-distingish-letter-in-non-POSIX-locales.patch
Description: Text Data

Attachment: 0004-dfa-don-t-treat-null-bytes-specially.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]