bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#18762: [PATCH] dfa: don't consider RE_DOT_NEWLINE and RE_DOT_NOT_NUL


From: Norihiro Tanaka
Subject: bug#18762: [PATCH] dfa: don't consider RE_DOT_NEWLINE and RE_DOT_NOT_NULL in matching with a bracket expression
Date: Sun, 19 Oct 2014 08:30:06 +0900

Thanks for the review.

This is a potential bug fix.  However, match_mb_charset function isn't
used in grep and gawk, as DFA treats MBCSET as BACKREF by following code
if `backref' is provided.  Therefore the fix never induces any semantic
change in grep and gawk.

              if (d->states[s].has_mbcset && backref)
                {
                  *backref = 1;
                  goto done;
                }

Essentially, the function is able to be removed.  However, if we regard
DFA as a library,  we should keep it.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]