bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#18580: [PATCH] dfa: check end of an input buffer after a transition


From: Norihiro Tanaka
Subject: bug#18580: [PATCH] dfa: check end of an input buffer after a transition in non-UTF8 multibyte locales
Date: Mon, 29 Sep 2014 14:58:38 +0900

Thanks for the review.

> Thanks, can you provide a test case that illustrates the problem?  We
> could add it to the test suite.

I checked both values of `p' and `end' after first transit_state in
following operation with GDB, but I can't have generated core dump by
this bug yet.

  $ echo | env LC_ALL=ja_JP.eucJP src/grep '..........'

> Also, there are two calls to transit_state but that patch affects only
> one of them.  Why shouldn't both calls be patched?

I only tested at the first call of transit_state (because above test case
doesn't pass the second call), but I think that we also fix at the second
call as you say.

Attachment: 0001-dfa-check-end-of-an-input-buffer-after-a-transition-.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]