bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17246: grep-2.19 planning


From: Paolo Bonzini
Subject: bug#17246: grep-2.19 planning
Date: Thu, 15 May 2014 14:39:23 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 15/05/2014 14:34, Norihiro Tanaka ha scritto:
* src/Makefile.am (bin_PROGRAMS): Add egrep, fgrep.
(bin_SCRIPTS): Remove it.
(grep_SOURCES): Move searchutils.c, dfa.c, dfasearch.c, kwset.c,
kwsearch.c, pcresearch.c here to libgrep_a_SOURCES.
(egrep_SOURCES, fgrep_SOURCES): New macro.
(noinst_LIBRARIES): Add libgrep.a.
(libgrep_a_SOURCES): Move searchutils.c, dfa.c, dfasearch.c, kwset.c,
kwsearch.c, pcresearch.c here from grep_SOURCES.
(LDADD): Add libgrep.a.
(egrep, fgrep): Use rule of grep.
(CLEANFILES): Remove macro.
* src/grep.c (SELECTED_MATCHER, DEFAULT_MATCHER): New macro.
(do_execute, usage, matchers, main): Use them.
*  src/egrep.c: Define SELECTED_MATCHER macro for egrep.
*  src/fgrep.c: Define SELECTED_MATCHER macro for fgrep.
---

I disagree a bit with introducing subtle changes over the 2.18 logic. Also, the large diff makes it hard to review the changes (both their logic and their merit).

We should apply the basic revert patch, and then do cleanups on top.

Paolo





reply via email to

[Prev in Thread] Current Thread [Next in Thread]