|
From: | Paul Eggert |
Subject: | bug#17350: [PATCH] grep: speed up for a case to repeat failure in DFA after success in kwset |
Date: | Tue, 06 May 2014 18:45:25 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Norihiro Tanaka wrote:
Paul Eggert wrote:Anyway, I reworded the text in a different way to avoid the misuse of "if" (third attached patch).By the way, do you purposely replace spaces with tabs in third patch?
Yes, we're using tabs to line up code that is multicolumn (typically the first column is code, the second comments). Admittedly the code is not consistent in this area.
I'd prefer a different style, where there's a comment on one line and code on the next, and where there are no tabs, but now's not a good time to change styles.
[Prev in Thread] | Current Thread | [Next in Thread] |