[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: UTF-16 surrogate pair handling in grep -i option

From: Paolo Bonzini
Subject: Re: UTF-16 surrogate pair handling in grep -i option
Date: Tue, 20 Aug 2013 16:18:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

Il 16/08/2013 16:42, Jim Meyering ha scritto:
> Hi Corina,
> Thanks a lot for the patcb.  It is almost perfect.
> [ - the git one-line summary should be readable.
>   - comment nit: s/  as/  as a/
>   - a style issue: we want curly braces around the 1-line
>   else body in the first #ifdef block
>   - please attribute the reporter (or a list URL) in the commit log
> ]
> Do any of the existing tests trigger this malfunction?
> If not, can you create a small example that triggers the
> problem on cygwin?  Even better would be the addition of a new
> script in tests/, which is required for any bug-fix patch.
> Also, it'd be great if you would add a NEWS entry that
> describes your fix.  That said, there's no pressure.
> If you can tell me how to reproduce the failure, I'll
> make time to write both the test and NEWS addition, and
> amend them onto your patch.
> PS. Your timing is great. I'm planning to make a release pretty soon.

Just one thing.  Would the patch be better conditionalized on "if
(sizeof (wchar_t) == 2)"?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]