[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug#669084: grep does not match anything when reading from stdin
From: |
Tino Keitel |
Subject: |
Re: Bug#669084: grep does not match anything when reading from stdin |
Date: |
Tue, 17 Apr 2012 14:23:48 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Apr 17, 2012 at 13:45:43 +0200, Jim Meyering wrote:
> Aníbal Monsalve Salazar wrote:
> ...
> > Hello Jim,
> >
> > grep-2.11 introduced a regression related to the "-D skip" parameter
> > option.
> >
> > With grep-2.10 (or less than 2.10):
> >
> > $ echo foo | grep -D skip foo; echo $?
> > foo
> > 0
> >
> > With grep-2.11:
> >
> > $ echo foo | grep -D skip foo; echo $?
> > 1
> >
> > Timo suggests that the possible culprit is the code above.
> >
> > The Debian bug report is at http://bugs.debian.org/668585
>
> Hi Aníbal
>
> Thanks for passing that along.
> Here's a lightly-tested patch:
Hi,
I had problems extracting the patch from the mail, so I had to use
copy&paste. Also, the patch portion in main.c looked totally different
than my main.c from 2.11. I added the "desc != STDIN_FILENO" and the
brackets manually and it fixed the -D skip behaviour.
Regards,
Tino