[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] grep: be quiet about GREP_COLORS syntax
From: |
Paul Eggert |
Subject: |
Re: [PATCH 4/4] grep: be quiet about GREP_COLORS syntax |
Date: |
Sun, 22 Jan 2012 01:10:07 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111124 Thunderbird/8.0 |
On 01/20/2012 11:46 PM, Paolo Bonzini wrote:
> All patches look good! Can you write a NEWS entry and push?
Sure, I pushed this NEWS change along with the rest.
Thanks for reviewing.
doc: document recent diagnostics-related changes
* NEWS: Document changes re diagnostics related to GREP_COLORS,
directory loops, -s, "write error".
diff --git a/NEWS b/NEWS
index b36cab7..1d687ec 100644
--- a/NEWS
+++ b/NEWS
@@ -9,6 +9,15 @@ GNU grep NEWS -*- outline
-*-
read error on most systems; formerly, it ignored the error.
[bug introduced in grep-2.5]
+ grep now exits with status 2 if a directory loop is found,
+ instead of possibly exiting with status 0 or 1.
+ [bug introduced in grep-2.3]
+
+ The -s option now suppresses certain input error diagnostics that it
+ formerly failed to suppress. These include errors when closing the
+ input, when lseeking the input, and when the input is also the output.
+ [bug introduced in grep-2.4]
+
On POSIX systems, commands like "grep PAT < FILE >> FILE"
now report an error instead of looping.
[bug present since "the beginning"]
@@ -47,6 +56,13 @@ GNU grep NEWS -*- outline
-*-
Use of the --mmap option now elicits a warning. It has been a no-op
since March of 2010.
+ grep no longer diagnoses write errors repeatedly; it exits after
+ diagnosing the first write error. This is better behavior when
+ writing to a dangling pipe.
+
+ Syntax errors in GREP_COLORS are now ignored, instead of sometimes
+ eliciting warnings. This is more consistent with programs that
+ (e.g.) ignore errors in termcap entries.
* Noteworthy changes in release 2.10 (2011-11-16) [stable]