[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] colorize: use isatty module
|
From: |
Jim Meyering |
|
Subject: |
Re: [PATCH 1/3] colorize: use isatty module |
|
Date: |
Tue, 03 Jan 2012 09:48:36 +0100 |
Paolo Bonzini wrote:
> * bootstrap.conf: Add isatty module.
> * gnulib: Update to latest.
> * lib/colorize.h: Remove argument from should_colorize.
> * lib/ms/colorize.h: Likewise.
> * lib/colorize-impl.c: Factor isatty call out of here...
> * lib/ms/colorize-impl.c: ... and here...
> * src/main.c: ... into here.
Hi Paolo,
At least with gcc-4.7.0 20120102, a warning-enabled build now fails like this:
colorize.c: In function 'init_colorize':
colorize.c:37:6: error: function might be candidate for attribute 'const'
[-Werror=suggest-attribute=const]
cc1: all warnings being treated as errors
[PATCH 2/3] unify colorize.h headers, Paolo Bonzini, 2012/01/03
[PATCH 3/3] remove lib/ms/, Paolo Bonzini, 2012/01/03