bug-grep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 30/34] maint: dfa: simplify several expressions


From: Jim Meyering
Subject: Re: [PATCH 30/34] maint: dfa: simplify several expressions
Date: Thu, 15 Sep 2011 13:29:32 +0200

Paolo Bonzini wrote:

> On 09/15/2011 12:28 PM, Jim Meyering wrote:
>> -#if MBS_SUPPORT
>>     d->mb_cur_max = MB_CUR_MAX;
>
> d->mb_cur_max = MBS_SUPPORT ? MB_CUR_MAX : 1

That's tempting, but not needed.
MB_CUR_MAX is already defined appropriately, so what's there is fine:

       d->mb_cur_max = MB_CUR_MAX;

>>     if (d->mb_cur_max>  1)
>>       {
>>         d->nmultibyte_prop = 1;
>> @@ -3417,7 +3417,6 @@ dfainit (struct dfa *d)
>>         d->mbcsets_alloc = 1;
>>         MALLOC(d->mbcsets, d->mbcsets_alloc);
>>       }
>> -#endif



reply via email to

[Prev in Thread] Current Thread [Next in Thread]