[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] Prevent creation of /t

From: Jim Meyering
Subject: Re: [Patch] Prevent creation of /t
Date: Wed, 31 Aug 2011 21:21:20 +0200

Matthew Burgess wrote:
> The unibyte-bracket-expr test does 'cp $in /t' which, if the tests are
> being run as root, will cause '/t' to be created (and obviously, if
> the tests aren't being run as root, that command should fail).  The
> attached patch simply removes that copy command, as that didn't affect
> the status of the test on my machine (x86 Linux) and I couldn't see
> any other reference to '/t'.

Thanks again.
Here's the patch I expect to push in your name.
Since you're listed as "Author", yet I wrote the log entry,
I'll wait for your ACK before pushing it.

>From a7e745b9d40e3c94cc5527a257c37f334fa0c9d0 Mon Sep 17 00:00:00 2001
From: Matthew Burgess <address@hidden>
Date: Wed, 31 Aug 2011 21:18:54 +0200
Subject: [PATCH] tests: remove debug code that would cp to /t

* tests/unibyte-bracket-expr: Remove debug artifact introduced
by 2011-06-02 commit de5f7000, "tests: exercise a uni-byte [...]
bug: requires ru_RU.KOI8-R".  [bug introduced in grep-2.9]
 tests/unibyte-bracket-expr |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/tests/unibyte-bracket-expr b/tests/unibyte-bracket-expr
index a0b51dd..45ad5d9 100755
--- a/tests/unibyte-bracket-expr
+++ b/tests/unibyte-bracket-expr
@@ -32,7 +32,6 @@ for i in 8 9 a b c d e f; do
     b=$(printf "\\x$i$j")
     echo "$b" > $in || framework_failure_
-    cp $in /t
     grep "[$b]" $in > out || fail=1
     compare out $in || fail=1

reply via email to

[Prev in Thread] Current Thread [Next in Thread]