[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: stop using .x-sc_* files to list syntax-check exempti
Re: [PATCH] maint: stop using .x-sc_* files to list syntax-check exemptions
Wed, 30 Mar 2011 10:28:29 +0200
Paolo Bonzini wrote:
> On 03/19/2011 06:35 PM, Jim Meyering wrote:
>> +exclude_file_name_regexp--sc_space_tab = ^gl/lib/.*\.c\.diff$$
> .diff and .patch files should probably be exempted from this rule at
> the gnulib level, no?
I debated that.
However, a patch will contain a space-TAB only if the original source
contains a leading TAB in a context line, and with the no-leading-TAB
policy used by a few projects, such a diff would only apply to exempt
files, like Makefile.am.
Always exempting .diff and .patch files would let those files
introduce inadvertent space-TAB. In some projects, those
files we need to exempt (and patches applying to them)
are truly exceptional, so it makes sense to have to list them.
The exempted .diff files referred to above apply to C source files
from glibc; they contain lines starting with TAB.
As such, I would prefer not to always exempt them.