Re: pcre.h failure in grep-2.5.4-20090126

[Tony Abou-Assaleh]

Karl Berry wrote:
> In grep-2.5.4-20090126, search.c says:
> 
> #ifdef HAVE_LIBPCRE
> # include <pcre.h>
> #endif
> 
> Unfortunately this does not work on my system, which is the oldish
> Red Hat WS 4 (but compiling with the newish gcc 4.2.4).  On that system,
> it's <pcre/pcre.h>.  When I change the #include, everything compiles
> (with some mbs warnings), and all tests pass.
> 
> It would suffice to add a check for <pcre.h> and simply disable pcre if
> it doesn't exist -- no real need to cater for this old system (although
> if you want to check for <pcre/pcre.h>, fine too).  Hmm, there used to
> be a configure option for it, but I see it's been "improved" to use
> pcre-config and there is no manual override, so I don't know what to do.

There was a patch somewhere for dynamic loading of the PCRE library.
Would that solve this problem?

Any indication in the output of pcre-config that pcre.h is in pcre/?

I don't have access to such a system, so it's hard to investigate
further. The current plan is to leave it as; the PCRE support is still
experimental anyway and needs much improvement from what I recall.

Note to self: test grep with and without PCRE. Apparently PCRE support
is only available if the libpcre-dev is installed (or a newer version).
We should mention this dependency somewhere.

As a general rule, I think test cases that are skipped should be voiced
 as skipped and why skipped, not silently ignored as is the case right now.

Cheers,

TAA

-- 
Tony Abou-Assaleh, PhD
Email:    address@hidden
Web site: http://tony.abou-assaleh.net