[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

dfa.c: fix memory leak

From: Aharon Robbins
Subject: dfa.c: fix memory leak
Date: Thu, 04 Dec 2008 23:13:51 +0200

Hi. Here is a patch for a bug that I just (re-)fixed in gawk.

It looks like there has not been much activity in the CVS in a long
while. Sigh.

In any case, valgrind is your friend; this showed up in gawk in a UTF-8

In general, it is worth comparing the gawk dfa.c with the grep one; I
have fixed a few bugs there.

2008-12-04  Arnold D. Robbins <address@hidden>

        * src/dfa.c (parse_bracket_exp_mb): Don't set work_mbc->chars
        to NULL to not leak the memory allocated a few lines earlier.

Index: dfa.c
RCS file: /sources/grep/grep/src/dfa.c,v
retrieving revision 1.39
diff -u -r1.39 dfa.c
--- dfa.c       10 Feb 2008 03:16:10 -0000      1.39
+++ dfa.c       4 Dec 2008 21:10:13 -0000
@@ -529,7 +529,6 @@
   work_mbc->nchars = work_mbc->nranges = work_mbc->nch_classes = 0;
   work_mbc->nequivs = work_mbc->ncoll_elems = 0;
-  work_mbc->chars = NULL;
   work_mbc->ch_classes = NULL;
   work_mbc->range_sts = work_mbc->range_ends = NULL;
   work_mbc->equivs = work_mbc->coll_elems = NULL;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]