Re: [patch #4604] Fix left anchors and -w problems

[Julian Foad]

Charles Levert wrote:
>  <http://savannah.gnu.org/patch/?func=detailitem&item_id=4604>
>  <http://savannah.gnu.org/patch/download.php?item_id=4604&item_file_id=5449>

> The following set of changes make previously failing tests relative to left
> anchors (^ and \<) and -w pass.

Excellent.

> It should address the issues raised in bug #11579 and patch #1834.

Yes, I confirm it does.

> It now makes fmbtest.sh Test #6 (G and E) fail, but isn't it that test that
> has wrong expectations?  (Test that -{G,E} --color=always prefers earlier
> pattern matches.  Earlier as in -e/-f order.)

As far as I can see, the test matches its description, and your log message 
says that your code is intended to do that (prefer matches with earlier 
patterns), but grep in fact colours text that matches a later pattern.  This 
indicates a bug.

Did you have anything in particular in mind when you asked "isn't it that test 
that has wrong expectations?"?  As far as I can see, that test's expectation 
matches your description of your patch.


Other than that, my only comment is please could you put a doc string on the 
typedef or #define for the "execute" functions that states, at the very least, 
the special meaning of "start_pos == -1".  And/or use a defined constant with a 
suitable name instead of the "(size_t) -1".  Thanks.

- Julian