[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug-grep] PARAMS, gnulib update and const
From: |
Claudio Fontana |
Subject: |
[bug-grep] PARAMS, gnulib update and const |
Date: |
Sun, 20 Mar 2005 01:46:43 +0100 (CET) |
Hello,
two suggestions for review:
gnulib has removed PARAMS and thus support for pre-c89
compilers in 2003.
By importing gnulib, we will have some code using
PARAMS and some code assuming c89 or better compiler.
I would suggest following the gnulib and removing the
PARAMS clutter entirely. The alternative of importing
gnulib, then patching it to add PARAMS seems
unpratical to me.
In grep we have a pervasive use of const. It might be
a matter of taste, but personally I find const
useless, but what matters more is that the current
code casts away const when needed. I would suggest a
hunt-the-const.
If you generally agree, I would like to prepare two
patches addressing these issues.
Claudio
___________________________________
Nuovo Yahoo! Messenger: E' molto più divertente: Audibles, Avatar, Webcam,
Giochi, Rubrica
Scaricalo ora!
http://it.messenger.yahoo.it
- [bug-grep] PARAMS, gnulib update and const,
Claudio Fontana <=