Re: [bug-grep] suggested patch for mbsupport.h

[Aharon Robbins]

I don't have check in ability. Whoever checks in the patch can
do that.  I'll fix it in the gawk sources though.  Thanks.

Arnold

> From address@hidden  Tue Feb  8 21:45:46 2005
> Date: Tue, 08 Feb 2005 18:49:48 +0000
> From: Julian Foad <address@hidden>
> Subject: Re: [bug-grep] suggested patch for mbsupport.h
> To: Aharon Robbins <address@hidden>
> Cc: address@hidden
> Reply-to: address@hidden
> Content-type: text/plain; charset=UTF-8; format=flowed
> Content-transfer-encoding: 7bit
> X-Accept-Language: en-gb, en, en-us
> Original-recipient: rfc822;address@hidden
> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on aahz
> X-Spam-Level: 
> X-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham 
>       version=2.63
>
>
> Aharon Robbins wrote:
> > The wording is still not generic enough in the explanatory comment.
> > Patch attached.
>
> While you're changing the comment, maybe you could correct "1i8n" to "i18n" 
> in 
> its first line.
>
> - Julian
>
>
> > 
> > Enjoy,
> > 
> > Arnold
> > -------------------------------------
> > 2005-02-08  Arnold D. Robbins  <address@hidden>
> > 
> >     * mbsupport.h: Make wording in explanatory comment
> >     more generic.
> > 
> > Index: mbsupport.h
> > ===================================================================
> > RCS file: /cvsroot/grep/grep/src/mbsupport.h,v
> > retrieving revision 1.3
> > diff -u -r1.3 mbsupport.h
> > --- mbsupport.h     8 Feb 2005 10:58:30 -0000       1.3
> > +++ mbsupport.h     8 Feb 2005 14:40:31 -0000
> > @@ -21,12 +21,13 @@
> >     02111-1307, USA.  */
> >  
> >  /*
> > - * This file is needed because we test for 1i8n support in 3 different
> > - * places, and we want a consistent definition in all of them.  Following
> > - * the ``Don't Repeat Yourself'' principle from "The Pragmatic Programmer",
> > - * we centralize the tests here.
> > + * This file is needed so that we test for 1i8n support in just one place.
> [...]
>
>
> #####################################################################################
> This Mail Was Scanned by 012.net Anti Virus Service - Powered by TrendMicro 
> Interscan
>