Re: [bug-grep] grep patch proposal (-p, --position new option)

[Claudio Fontana]

 --- Stepan Kasal <address@hidden> ha scritto: 
> Hi Claudio,
> 
> On Tue, Dec 14, 2004 at 06:47:13AM +0100, Claudio
> Fontana wrote:
> > My proposal is to add a "-p, --position" option
> with
> 
> I'm afraid that you spent your time for a work which
> Icannot accept.

No ai problema, I took the opportunity to learn the
grep source better.

I don't want to be --pedantic, however I noticed these
three trivial cosmetic issues:

- at line 527, local variable ilim is never used.
          char *ilim = ibeg + (lim - beg);

- spacing after if is sometimes incoherent. Mostly
it's if (condition), however sometimes it's
if(condition);

- likewise, mostly it's a - b, however sometimes it's
a-b.

I don't know if you're sensible to these things, so I
just tell you.

> I hope this won't distaste you so much that you'd
> leave the grep community.

Of course not, it was just a proposal and as such can
be rejected :)

Claudio



                
___________________________________ 
Nuovo Yahoo! Messenger: E' molto più divertente: Audibles, Avatar, Webcam, 
Giochi, Rubrica… Scaricalo ora! 
http://it.messenger.yahoo.it