Re: [bug-grep] Re: grep: very large file with no newline causes trouble

[Jim Meyering]

Hi Stepan,

> The patch is attached to this mail; could someone please review
> it and test it?  After a positive review, I'll check it in.

I haven't tested it, but did see one nit.
Here, I suggest you just set errno not to saved_errno
but rather to ENOMEM, since saved_errno's value is not useful.

>        for (newsize = bufalloc - pagesize - 1; newsize < minsize; newsize *= 
> 2)
>       if (newsize * 2 < newsize || newsize * 2 + pagesize + 1 < newsize * 2)
> -       xalloc_die ();
> +       {
> +         int saved_errno = errno;
> +         free (buffer);
> +         buffer = NULL;
> +         errno = saved_errno;
> +         return 0;
> +       }