Re: [bug-grep] [patch] getting '--devices=skip' to work

[Elliott Hughes]

the trouble with checking-before-doing is that things can change in 
between. in this case, though, i agree that it looks like the better 
choice.

--
http://www.jessies.org/~enh/

On Nov 18, 2004, at 23:36, Stepan Kasal wrote:

> Hello Tim,
>
> > > >      while ((desc = open (file, O_RDONLY | O_NONBLOCK)) < 0
> > > >              && errno == EINTR)
>
> my intuition was that it's safer to find out that we don't want to grep
> the file before we try to open it.
>
> > Stop the bus!  There is a kernel change to do with opening normal
> > files with O_NONBLOCK having unexpected consequences.  It's best
> > avoided.
>
> Together with this comment from Tim, O_NONBLOCK is out of question.
> But I'll probably check in Benno's patch.
>
> Yours,
>         Stepan