[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-gnuzilla] Installer doesn't recognize new manifest files
From: |
Mark H Weaver |
Subject: |
Re: [Bug-gnuzilla] Installer doesn't recognize new manifest files |
Date: |
Thu, 16 May 2019 05:10:55 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) |
Hi Rubén,
Ruben Rodriguez <address@hidden> writes:
> That was corrected in commit
> http://git.savannah.gnu.org/cgit/gnuzilla.git/commit/?id=7859a9131fcda359265dc16ef55933e5ed218119
While looking at the recent batch of commits, I was glad to see that you
removed the debian-specific code from makeicecat. Thank you for that.
However, there's a problem in this commit:
https://git.savannah.gnu.org/cgit/gnuzilla.git/commit/?id=854456185c7ab011895c20af3572361defec9751
It leaves two nearly identical lines next to each other in makeicecat:
cp $DATA/Changelog.IceCat $DATA/README.IceCat .
cp $DATA/Changelog.IceCat $DATA/README.IceCat
The second command overwrites README.IceCat with the contents of
Changelog.IceCat. Moveover, a subsequent commit
c624e1cd39a4e61f1924e153293e74e89e134a68 does exactly that:
https://git.savannah.gnu.org/cgit/gnuzilla.git/commit/?id=c624e1cd39a4e61f1924e153293e74e89e134a68
The above commit replaces README.IceCat with a copy of Changelog.IceCat.
You might want to fix that.
Also, are you planning to distribute a signed icecat-60.6.3 source
tarball soon? I'd like to incorporate your updates into the Guix IceCat
package, but I'm reluctant to do so without a digital signature,
especially to authenticate the updated plugins.
Thanks,
Mark