[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #6630] Patch to always check -isFlipped as Cocoa does rather than
From: |
Fred Kiefer |
Subject: |
[patch #6630] Patch to always check -isFlipped as Cocoa does rather than accessing the flag directly |
Date: |
Sun, 07 Sep 2008 12:13:29 +0000 |
User-agent: |
Mozilla/5.0 (compatible; Konqueror/3.5; Linux) KHTML/3.5.9 (like Gecko) SUSE |
Follow-up Comment #3, patch #6630 (project gnustep):
Good point. I would expect that the optimisation is used less then five times
per drawing request on each view. But it will be hard to count.
A grep on flipped_view shows that this mostly is used for NSScrollView and
there is another hack in place for NSClipView.
(Apart from the usage in NSView and one marginal case in NSSplitView) Only
the usage in NSView could be performance critical, as far as I can tell.
My current idea is to set this variable in _rebuildCoordinates, that way we
have the correct value and as long as nothing changes the method wont get
called.
Still, if the ivar only gets used as little as we all expect, we might as
well remove it.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?6630>
_______________________________________________
Nachricht geschickt von/durch Savannah
http://savannah.gnu.org/