Re: [bug #4658] Broken gpbs when doing pb operations between GS and X

[Kazunobu Kuriyama]

Richard Frith-Macdonald wrote:

> On Friday, August 8, 2003, at 10:58 AM, Kazunobu Kuriyama wrote:
>
> > > 2. It is not possible to copy from X and paste in GNUstep strings 
> > > longer than 1024 characters.
> >
> >
> > It seems that this is due not to gpbs, but to the implementation of 
> > NSSerializer.
> > In the method + (NSData*) serializePropertyList: (id)propertyList, we 
> > have
> >
> >   d = [NSMutableData dataWithCapacity: 1024];
> >
> > I hope the limitation will be lifted once someone changes the magic 
> > number 1024,
> > though I'm not sure if it is possible.
>
>
> No, it's not due to that ... the capacity specifies the initial memory 
> size of the data object,
> not a limit ... you can serialize megabytes of data reasonably 
> efficiently. 

I just remember the original implementation calls XGetWindowProperty() 
with the statically fixed
value FULL_LENGTH (=8192L), which means the whole (X's) property data 
can't be retrieved at
once unless it is small enough.  Perhaps, this is the true reason, 
though I'm not sure then why
the number 1024 appears in the bug report.  Also, because 
XGetWindowProperty() is called only
once, the original code doesn't count the case where property data can't 
be retrieved at once.

I think the bug will go away if we fix that part of the code.