Re: [Bug-gnupod] Bug fixes for gnupod.

[Brad]

----- Original message -----
> Hello Brad,
> 
> Thanks for the ffmpeg fixes, they look very useful.
> 
> On 30-5-11 22:39 , Brad wrote:
> > printf "%s" "checking for ImageMagick..."
> > convert --version > /dev/null 2>&1
> > - if test $? = 0; then
> > + if test $? = 1; then
> 
> This change is incorrect. Convert returns 0 when it exists. A non-zero
> result is expected when it does not exist.
> 
> $ convert --version
> Version: ImageMagick 6.6.4-0 2010-09-18 Q16 http://www.imagemagick.org
> Copyright: Copyright (C) 1999-2010 ImageMagick Studio LLC
> Features: OpenMP
> 
> $ echo $?
> 0
> $ notthere --version
> -bash: notthere: command not found
> $ echo $?
> 127
> 
> However, the check in configure is informative only. The result is not
> used in the perl code of gnupod.

I'll have to check the version I am using when I get home but it returns 1 
instead of 0. I changed it specifically because the test was failing to detect 
the presence of ImageMagick even though its there.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.