Re: warnings from gzip and diffutils

[Bruno Haible]

Paul Eggert wrote:
> On 2024-12-17 17:21, Bruno Haible via Gnulib discussion list wrote:
> > Therefore, how about applying -Werror only to a subset of all
> > warnings, hand-picked by the maintainer?
> 
> We already tailor warnings from Gnulib as opposed to warnings from the 
> main program

Oh I see: Code that sets GNULIB_WARN_CFLAGS is already present in
gzip/configure.ac (and likewise in coreutils, grep, tar) but not yet in
diffutils/configure.ac.

  # We use a slightly smaller set of warning options for lib/.
  # Remove the following and save the result in GNULIB_WARN_CFLAGS.
  nw=
  ...
  gl_MANYWARN_COMPLEMENT([GNULIB_WARN_CFLAGS], [$WARN_CFLAGS], [$nw])
  AC_SUBST([GNULIB_WARN_CFLAGS])

How about adding this block to the configure.ac of 
  diffutils
  bison
  m4
  sed
that use the same idiom? Even if for the moment, nw remains empty here,
the comment would make it clear that this is the mechanism to disable
some warning options for lib/, and this would reduce the pressure on
gnulib do placate style warnings like the two recent ones.

Bruno